Skip to content

Add return type to getIterator() methods - #312

Merged
oscarotero merged 1 commit into
php-gettext:masterfrom
swissspidy:fix/rector-iterator-return-types
Nov 18, 2026
Merged

oscarotero merged 1 commit into
php-gettext:masterfrom
swissspidy:fix/rector-iterator-return-types

Conversation

@swissspidy

Copy link
Copy Markdown
Contributor

Rector's AddReturnTypeDeclarationBasedOnParentClassMethodRector now reports these five methods, which makes the Rector check fail.

Claude-Session: https://claude.ai/code/session_01UWTd5qmztfFv37ybV4xsjV

@swissspidy
swissspidy marked this pull request as ready for review November 17, 2026 16:28
Copilot AI balanced review requested due to automatic review settings November 17, 2026 16:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@oscarotero

Copy link
Copy Markdown
Member

Thanks, the changes are good.
Is it possible to remove claude as co-author? It's okay if you use it to help you, but I'd like to keep this project await from AI code generation. If it's not possible, I'll merge it anyway.

Rector's `AddReturnTypeDeclarationBasedOnParentClassMethodRector` now
reports these five methods, which makes the Rector check fail.
@swissspidy
swissspidy force-pushed the fix/rector-iterator-return-types branch from d11edf9 to 584ff05 Compare November 18, 2026 12:59
@swissspidy

Copy link
Copy Markdown
Contributor Author

@oscarotero Done!

@oscarotero
oscarotero merged commit b2d33d1 into php-gettext:master Nov 18, 2026
9 checks passed
@oscarotero

Copy link
Copy Markdown
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants